Use of standard module optparse for command line parsing in ffx-backup.py

ffx-backup.py

@@ -12,22 +12,28 @@ EXCLUDES = [
     "/.parentlock$",
 ]
 
-import time, os, os.path, re, sys, tarfile
-
-if len(sys.argv) != 2 and len(sys.argv) != 4:
-    print "Usage: %s path_to_profile [filedropper_username filedropper_password]" % sys.argv[0]
+import os, os.path, re, sys, tarfile, time
+from optparse import OptionParser
+
+# Parse command line
+parser = OptionParser()
+parser.add_option("-f", "--folder", dest="profile_path", help="profile folder to be saved")
+parser.add_option("-u", "--user", dest="fd_user", help="username for connection to FileDropper (optional)")
+parser.add_option("-p", "--password", dest="fd_pass", help="password for connection to FileDropper (optional)")
+(options, args) = parser.parse_args()
+
+# Check if constraints are respected
+if options.profile_path is None:
+    print "No profile specified"
+    sys.exit(1)
+if (options.fd_user is not None and options.fd_pass is None) or (options.fd_user is None and options.fd_pass is not None):
+    print "Username AND password needed"
     sys.exit(1)
 
-profile_path = sys.argv[1]
-profile_name = os.path.basename(profile_path)
+profile_name = os.path.basename(options.profile_path)
 date = time.strftime("%Y%m%d_%H%M%S")
 archive_name = "%s-%s.tar.bz2" % (profile_name, date)
 
-fd_user = None
-fd_pass = None
-if len(sys.argv) == 4:
-    fd_user, fd_pass = sys.argv[2], sys.argv[3]
-
 # Compile exclusion regexps
 EXCLUDES_RE = []
 for regexp in EXCLUDES:
@@ -50,7 +56,7 @@ def is_excluded(filename):
 tar = tarfile.open(archive_name, 'w:bz2')
 
 # Add the data to the archive
-tar.add(profile_path, profile_name, exclude=is_excluded)
+tar.add(options.profile_path, profile_name, exclude=is_excluded)
 
 tar.close()
 
@@ -59,11 +65,11 @@ print "Profile saved to %s" % archive_name
 print "%.1f MB --> %.1f MB" % (total_size/(1024**2), os.path.getsize(archive_name)/(1024**2))
 
 # Upload to FileDropper if needed
-if fd_user is not None and fd_pass is not None:
+if options.fd_user is not None and options.fd_pass is not None:
     import FileDropper
 
     fd = FileDropper.FileDropper()
-    fd.login(fd_user, fd_pass)
+    fd.login(options.fd_user, options.fd_pass)
 
     # Upload the file
     url = fd.upload(archive_name)